XiangpengHao commented on PR #6039: URL: https://github.com/apache/arrow-rs/pull/6039#issuecomment-2223171140
I've kept the api unchanged, but updated the code to not using it. So it should not break any existing code. Once we are ready to introduce api change, we should replace https://github.com/XiangpengHao/arrow-rs/blob/buffer-api/arrow-buffer/src/buffer/immutable.rs#L361-L370 with ```rust impl From<&[u8]> for Buffer { fn from(p: &[u8]) -> Self { Self::from_slice_ref(p) } } impl<const N: usize> From<[u8; N]> for Buffer { fn from(p: [u8; N]) -> Self { Self::from_slice_ref(p) } } impl<const N: usize> From<&[u8; N]> for Buffer { fn from(p: &[u8; N]) -> Self { Self::from_slice_ref(p) } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
