felipecrv commented on code in PR #42133: URL: https://github.com/apache/arrow/pull/42133#discussion_r1674631765
########## cpp/src/arrow/type_fwd.h: ########## @@ -89,6 +89,9 @@ using ChunkedArrayVector = std::vector<std::shared_ptr<ChunkedArray>>; using RecordBatchVector = std::vector<std::shared_ptr<RecordBatch>>; using RecordBatchIterator = Iterator<std::shared_ptr<RecordBatch>>; +template <typename TypeClass> +class TypedArrayStatistics; Review Comment: A new typed class hierarchy for statistics seems like an overkill. Think of statistics as a dynamic object like `ArrayData` and the classes like `BooleanArray`, `StringArray` have typed accessors to the underlying untyped statistics object just like they have typed accessors to the underlying `ArrayData` for the array buffers of that type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
