nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r585139173
##########
File path: r/tests/testthat/test-python-flight.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip("Temporarily skip this")
Review comment:
Remove this (also why?)
##########
File path: r/data-raw/codegen.R
##########
@@ -194,10 +194,16 @@ arrow_exports_cpp <- glue::glue('
{feature_available("arrow")}
+{feature_available("dataset")}
Review comment:
It might be good to make these bits iterate over `features` rather than
copy-paste, just to help with future features.
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+skip_if_not_available("dataset")
Review comment:
You can skip a whole file like this? Cool.
##########
File path: r/tests/testthat/latin1.R
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-x <- iconv("Veitingasta�ir", to = "latin1")
+x <- iconv("Veitingasta�ir", to = "latin1")
Review comment:
Was this change intentional?
##########
File path: r/R/dataset-partition.R
##########
@@ -76,7 +76,9 @@ HivePartitioning$create <- dataset___HivePartitioning
#' calling `hive_partition()` with no arguments.
#' @examples
#' \donttest{
-#' hive_partition(year = int16(), month = int8())
+#' if (arrow_with_dataset()) {
Review comment:
Dev roxygen2 has an `@examplesIf` feature that might be better here. If
we put the conditional in the example code, it may suggest to the user that
they also need to check this every time, and generally they shouldn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
