alamb commented on code in PR #6015:
URL: https://github.com/apache/arrow-rs/pull/6015#discussion_r1680146902
##########
object_store/src/gcp/credential.rs:
##########
@@ -414,17 +417,28 @@ impl TokenProvider for InstanceCredentialProvider {
/// Fetch a token from the metadata server.
/// Since the connection is local we need to enable http access and don't
actually use the client object passed in.
+ /// References:
<https://googleapis.dev/python/google-auth/latest/reference/google.auth.environment_vars.html>
Review Comment:
```suggestion
/// Respects the `GCE_METADATA_HOST`, `GCE_METADATA_ROOT`, and
`GCE_METADATA_IP`
/// environment variables.
///
/// References:
<https://googleapis.dev/python/google-auth/latest/reference/google.auth.environment_vars.html>
```
##########
object_store/src/gcp/credential.rs:
##########
@@ -469,18 +483,30 @@ impl TokenProvider for InstanceSigningCredentialProvider {
/// Fetch a token from the metadata server.
/// Since the connection is local we need to enable http access and don't
actually use the client object passed in.
+ /// References:
<https://googleapis.dev/python/google-auth/latest/reference/google.auth.environment_vars.html>
Review Comment:
```suggestion
/// Respects the `GCE_METADATA_HOST`, `GCE_METADATA_ROOT`, and
`GCE_METADATA_IP`
/// environment variables.
///
/// References:
<https://googleapis.dev/python/google-auth/latest/reference/google.auth.environment_vars.html>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
