assignUser commented on code in PR #557: URL: https://github.com/apache/arrow-nanoarrow/pull/557#discussion_r1680392218
########## .github/workflows/docker-build.yaml: ########## @@ -14,7 +14,7 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -name: Build Docker Images +name: docker-build Review Comment: y? (not that I really mind) ########## .github/workflows/docker-build.yaml: ########## Review Comment: Hm it seems I missed this file in #540, sorry, the docker actions have new versions ########## .github/workflows/integration.yaml: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: integration + +on: + push: + branches: + - master + pull_request: + paths: + - .github/workflows/integration.yaml + - src/nanoarrow/** + +permissions: + contents: read Review Comment: :+1: ########## ci/docker/integration.dockerfile: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM apache/arrow-dev:amd64-conda-integration + +ENV ARROW_USE_CCACHE=OFF +ENV ARROW_CPP_EXE_PATH=/build/cpp/debug +ENV ARROW_NANOARROW_PATH=/build/nanoarrow +ENV ARROW_RUST_EXE_PATH=/build/rust/debug +ENV BUILD_DOCS_CPP=OFF +ENV ARROW_INTEGRATION_CPP=ON +ENV ARROW_INTEGRATION_CSHARP=ON +ENV ARROW_INTEGRATION_GO=ON +ENV ARROW_INTEGRATION_JAVA=ON +ENV ARROW_INTEGRATION_JS=ON +ENV ARCHERY_INTEGRATION_WITH_NANOARROW="1" +ENV ARCHERY_INTEGRATION_WITH_RUST="1" Review Comment: ```suggestion ENV ARROW_USE_CCACHE=OFF \ ARROW_CPP_EXE_PATH=/build/cpp/debug \ ARROW_NANOARROW_PATH=/build/nanoarrow \ ARROW_RUST_EXE_PATH=/build/rust/debug \ BUILD_DOCS_CPP=OFF \ ARROW_INTEGRATION_CPP=ON \ ARROW_INTEGRATION_CSHARP=ON \ ARROW_INTEGRATION_GO=ON \ ARROW_INTEGRATION_JAVA=ON \ ARROW_INTEGRATION_JS=ON \ ARCHERY_INTEGRATION_WITH_NANOARROW="1" \ ARCHERY_INTEGRATION_WITH_RUST="1" \ ``` Mostly preference though :) ########## ci/docker/integration.dockerfile: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM apache/arrow-dev:amd64-conda-integration + +ENV ARROW_USE_CCACHE=OFF +ENV ARROW_CPP_EXE_PATH=/build/cpp/debug +ENV ARROW_NANOARROW_PATH=/build/nanoarrow +ENV ARROW_RUST_EXE_PATH=/build/rust/debug +ENV BUILD_DOCS_CPP=OFF +ENV ARROW_INTEGRATION_CPP=ON +ENV ARROW_INTEGRATION_CSHARP=ON +ENV ARROW_INTEGRATION_GO=ON +ENV ARROW_INTEGRATION_JAVA=ON +ENV ARROW_INTEGRATION_JS=ON +ENV ARCHERY_INTEGRATION_WITH_NANOARROW="1" +ENV ARCHERY_INTEGRATION_WITH_RUST="1" Review Comment: ehh the whitespace didn't workout as expected in the comment editor ^^ :see_no_evil: ########## .github/workflows/integration.yaml: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: integration + +on: + push: + branches: + - master Review Comment: ```suggestion - main ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
