nevi-me commented on a change in pull request #9592:
URL: https://github.com/apache/arrow/pull/9592#discussion_r585250535
##########
File path: rust/parquet/src/schema/types.rs
##########
@@ -972,18 +1011,22 @@ fn from_thrift_helper(
}
/// Method to convert to Thrift.
-pub fn to_thrift(schema: &Type) -> Result<Vec<SchemaElement>> {
+pub fn to_thrift(schema: &Type, writer_version: i32) ->
Result<Vec<SchemaElement>> {
Review comment:
I see what you mean @sunchao. I've removed the version check, and always
write the logical type. I suppose I'm not thinking of this well from a
compatibility perspective. We'll always want to write complying with whatever
`parquet-format` version we're using.
There's still something that's unclear to me about how we'll deal with the
text schema format, but I can raise the questions when I work on its relevant
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
