alkis commented on code in PR #42174:
URL: https://github.com/apache/arrow/pull/42174#discussion_r1682972018
##########
cpp/tools/parquet/CMakeLists.txt:
##########
@@ -32,5 +32,16 @@ if(PARQUET_BUILD_EXECUTABLES)
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endforeach(TOOL)
+ # Only build parquet-dump-footer when statically linking.
Review Comment:
This is because thrift doesn't
`__declspec(dllexport)`/`__declspec(dllimport)` in the generated
`parquet_types.h` header. Do we want to redeclare those one by one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
