felipecrv commented on code in PR #43330:
URL: https://github.com/apache/arrow/pull/43330#discussion_r1685509464
##########
cpp/src/arrow/flight/types.cc:
##########
@@ -151,18 +151,57 @@ Status MakeFlightError(FlightStatusCode code, std::string
message,
std::make_shared<FlightStatusDetail>(code,
std::move(extra_info)));
}
-bool FlightDescriptor::Equals(const FlightDescriptor& other) const {
- if (type != other.type) {
- return false;
+static std::ostream& operator<<(std::ostream& os, std::vector<std::string>
values) {
Review Comment:
The `vector` here needs to be taken by `const &`. I will do this in another
PR. I just moved this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
