nealrichardson commented on a change in pull request #9618:
URL: https://github.com/apache/arrow/pull/9618#discussion_r585902139
##########
File path: r/R/dataset-write.R
##########
@@ -56,11 +56,12 @@
#' @export
write_dataset <- function(dataset,
path,
- format = dataset$format,
+ format = c("parquet", "feather", "arrow", "ipc"),
Review comment:
Need to update the docs to reflect the new behavior. You may (also) want
to borrow the language used to describe `format` from `dataset-format.R`.
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -1061,6 +1061,17 @@ test_that("Writing a dataset: Parquet->Parquet
(default)", {
)
})
+test_that("Writing a dataset: Not specified format", {
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-9651
+ dst_dir <- make_temp_dir()
+ write_dataset(mtcars, dst_dir)
+ new_ds <- open_dataset(dst_dir)
Review comment:
FWIW the default format for open_dataset() is parquet, so this test
would have failed if it hadn't written parquet files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
