alkis commented on code in PR #42174:
URL: https://github.com/apache/arrow/pull/42174#discussion_r1686303284
##########
cpp/tools/parquet/CMakeLists.txt:
##########
@@ -32,5 +32,16 @@ if(PARQUET_BUILD_EXECUTABLES)
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endforeach(TOOL)
+ # Only build parquet-dump-footer when statically linking.
Review Comment:
> Yeah, I'm thinking about the entire build size (including, potentially
unit tests, etc.).
Agreed if we were forcing static linking for unit tests that would add to
build time substantially. In this case though it was for a leaf binary so
perhaps it would have been ok.
In any case, moving the API inside libparquet solved this issue so now we
can link both static and dynamic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
