bkirwi commented on code in PR #6096:
URL: https://github.com/apache/arrow-rs/pull/6096#discussion_r1686874631
##########
arrow-row/src/lib.rs:
##########
@@ -868,6 +885,24 @@ impl Rows {
+ self.buffer.len()
+ self.offsets.len() * std::mem::size_of::<usize>()
}
+
+ /// Create a [BinaryArray] from the [Rows] data without reallocating the
+ /// underlying bytes.
+ pub fn into_binary(self) -> BinaryArray {
+ assert!(
Review Comment:
Open to it! Since array indices are signed ints, we'd need this assert in
any case, so I went with what seemed like the most common type. I don't feel
especially strongly about it though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
