sebdotv commented on code in PR #43360:
URL: https://github.com/apache/arrow/pull/43360#discussion_r1687638028
##########
go/parquet/pqarrow/file_reader.go:
##########
@@ -375,6 +375,12 @@ func (fr *FileReader) ReadRowGroups(ctx context.Context,
indices, rowGroups []in
data.data.Release()
}
+ if ctxErr := ctx.Err(); err == nil && ctxErr != nil {
+ // if the context is in error, but we haven't set an error yet,
then it means that the parent context
+ // was cancelled. In this case, we should exit early as some
columns may not have been read yet.
+ err = ctxErr
+ }
Review Comment:
Thanks, done! Looks like `errors.Join` was added in 1.20 and this repo uses
1.21+, so we should be good to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
