paddyhoran commented on a change in pull request #9602:
URL: https://github.com/apache/arrow/pull/9602#discussion_r586321776
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -517,20 +650,32 @@ where
},
);
- if !options.descending {
- valids.sort_by(|a, b| cmp_array(a.1.as_ref(), b.1.as_ref()))
+ let mut len = values.len();
+ let descending = options.descending;
+
+ if let Some(size) = limit {
+ len = size.min(len);
+ }
+
+ // we are not using partial_sort here, because array is ArrayRef.
Something is not working good in that.
Review comment:
What does "not working good" mean here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
