ericwburden commented on a change in pull request #9624:
URL: https://github.com/apache/arrow/pull/9624#discussion_r586482079
##########
File path: rust/arrow/src/array/array_binary.rs
##########
@@ -89,7 +89,7 @@ impl<OffsetSize: BinaryOffsetSizeTrait>
GenericBinaryArray<OffsetSize> {
// pointer alignment & location is ensured by RawPtrBox
// buffer bounds/offset is ensured by the value_offset invariants
std::slice::from_raw_parts(
- self.value_data.as_ptr().offset(start.to_isize()),
+ self.value_data.as_ptr().offset(start.to_isize().unwrap()),
Review comment:
Actually, now that I consider it, the implementation of `to_isize()`
that I removed from OffsetSizeTrait already had the unwraps, just inside the
`to_isize()` function instead of on the result of `to_isize()`. So, at the very
least, we shouldn't be adding any risks we weren't already taking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
