paleolimbot commented on code in PR #550:
URL: https://github.com/apache/arrow-nanoarrow/pull/550#discussion_r1693323233
##########
python/src/nanoarrow/_buffer.pyx:
##########
@@ -163,15 +193,31 @@ cdef DLDevice view_to_dlpack_device(CBufferView view):
raise ValueError('DataType is not compatible with DLPack spec: ' +
view.data_type)
# Define DLDevice struct
- if view._device.device_type_id == ARROW_DEVICE_CPU:
+ cdef ArrowDevice* arrow_device = view._event.device._ptr
+ if arrow_device.device_type is ARROW_DEVICE_CPU:
+ # DLPack uses 0 for the CPU device id where Arrow uses -1
device.device_type = kDLCPU
device.device_id = 0
else:
- raise ValueError('Only CPU device is currently supported.')
+ # Otherwise, Arrow's device identifiers and types are intentionally
+ # identical to DLPack
+ device.device_type = <DLDeviceType>arrow_device.device_type
+ device.device_id = arrow_device.device_id
Review Comment:
Good call! I think we have to add something to the device support library to
handle this since it's always an integer and has device-type specific meanings.
I pushed something here but I don't think `stream` is supposed to be a
`CUstream*` as a `uintptr_t` as I'd initially assumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
