felipecrv commented on code in PR #43415:
URL: https://github.com/apache/arrow/pull/43415#discussion_r1693479559
##########
cpp/src/arrow/compute/row/row_internal.cc:
##########
@@ -293,8 +293,12 @@ Status RowTableImpl::ResizeFixedLengthBuffers(int64_t
num_extra_rows) {
}
Status RowTableImpl::ResizeOptionalVaryingLengthBuffer(int64_t
num_extra_bytes) {
+ if (metadata_.is_fixed_length) {
+ return Status::OK();
+ }
Review Comment:
IMO it's more elegant to document that `ResizeOptional*VaryingLength*Buffer`
has a pre-condition
`/// \pre !metadata_.is_fixed_length`
Then you put a `DCHECK(!metadata_.is_fixed_length)` here and review the 2
callsites to ensure this is only called when the pre-condition is respected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
