bkietz commented on code in PR #43302: URL: https://github.com/apache/arrow/pull/43302#discussion_r1693565084
########## cpp/src/arrow/compute/kernels/scalar_cast_string.cc: ########## @@ -286,17 +288,20 @@ Status CastBinaryToBinaryOffsets<int64_t, int32_t>(KernelContext* ctx, } } +// Span -> Span Review Comment: I don't think it's used in this file, and span is probably too overloaded to use for this anywhere in arrow. ```suggestion // Offset String -> Offset String ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
