paleolimbot commented on code in PR #568:
URL: https://github.com/apache/arrow-nanoarrow/pull/568#discussion_r1693576289
##########
src/nanoarrow/ipc/decoder_test.cc:
##########
@@ -749,6 +749,53 @@ TEST_P(ArrowSchemaParameterizedTestFixture,
NanoarrowIpcArrowSchemaRoundtrip) {
ArrowIpcDecoderReset(&decoder);
}
+std::string ArrowSchemaToString(const struct ArrowSchema* schema) {
+ std::string out;
+ size_t n = 1024;
+ while (out.size() < n) {
+ out.resize(n);
+ n = ArrowSchemaToString(schema, out.data(), out.size(),
/*recursive=*/true);
+ }
+ return out;
+}
Review Comment:
This is nanoarrow's fault for not having a proper schema comparison;
however, this is technically not comparing metadata or flags. We could tack
those on to this output string or punt to a better schema comparison (your
call!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
