lidavidm commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1695084914
##########
java/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java:
##########
@@ -314,11 +331,6 @@ public MapWriter map(String name, boolean keysSorted) {
return getWriter(MinorType.STRUCT).${lowerName}(name);
}
- @Override
- public ${capName}Writer ${lowerName}() {
- return getWriter(MinorType.LIST).${lowerName}();
- }
-
Review Comment:
To be safe I would rather override rather than move functions in these core
APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
