vibhatha commented on code in PR #43503:
URL: https://github.com/apache/arrow/pull/43503#discussion_r1701169859
##########
java/dataset/src/test/java/org/apache/arrow/dataset/TestFragmentScanOptions.java:
##########
@@ -59,24 +71,29 @@ public void testCsvConvertOptions() throws Exception {
String path = "file://" + getClass().getResource("/").getPath() +
"/data/student.csv";
BufferAllocator allocator = new RootAllocator(Long.MAX_VALUE);
try (ArrowSchema cSchema = ArrowSchema.allocateNew(allocator);
+ ArrowSchema cSchema2 = ArrowSchema.allocateNew(allocator);
CDataDictionaryProvider provider = new CDataDictionaryProvider()) {
Data.exportSchema(allocator, schema, provider, cSchema);
- CsvConvertOptions convertOptions = new
CsvConvertOptions(ImmutableMap.of("delimiter", ";"));
- convertOptions.setArrowSchema(cSchema);
- CsvFragmentScanOptions fragmentScanOptions =
- new CsvFragmentScanOptions(convertOptions, ImmutableMap.of(),
ImmutableMap.of());
+ Data.exportSchema(allocator, schema, provider, cSchema2);
+ CsvFragmentScanOptions fragmentScanOptions1 =
+ create(cSchema, ImmutableMap.of(), ImmutableMap.of(),
ImmutableMap.of("delimiter", ";"));
+ CsvFragmentScanOptions fragmentScanOptions2 =
Review Comment:
Why would we use `fragmentScanOptions2`? Instead we should be able to use
`fragmentScanOptions1` (possibly rename to `fragmentScanOptions`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
