nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587609001
##########
File path: r/R/dataset-partition.R
##########
@@ -76,7 +76,9 @@ HivePartitioning$create <- dataset___HivePartitioning
#' calling `hive_partition()` with no arguments.
#' @examples
#' \donttest{
-#' hive_partition(year = int16(), month = int8())
+#' if (arrow_with_dataset()) {
Review comment:
Thanks, please also remove the conditionals from the other examples. I
don't feel strongly about `\donttest` vs `\dontrun` (CRAN complains about
dontrun examples on initial submission, which is why they were switched to
donttest in the first place, but that's not our concern now) so that's fine,
but FWIW `\donttest` is safe on Solaris: [we currently "pass" Solaris
checks](https://www.r-project.org/nosvn/R.check/r-patched-solaris-x86/arrow-00check.html)
with the fake arrow-without-arrow build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
