pitrou commented on a change in pull request #9528:
URL: https://github.com/apache/arrow/pull/9528#discussion_r587690293
##########
File path: cpp/src/arrow/util/thread_pool_test.cc
##########
@@ -137,30 +136,47 @@ class TestThreadPool : public ::testing::Test {
return *ThreadPool::Make(threads);
}
- void SpawnAdds(ThreadPool* pool, int nadds, AddTaskFunc add_func) {
- AddTester add_tester(nadds);
+ void SpawnAdds(ThreadPool* pool, int nadds, AddTaskFunc add_func,
+ StopToken stop_token = StopToken::Unstoppable(),
+ StopSource* stop_source = nullptr) {
Review comment:
Passing the token with not the source tests a source that's not stopped,
so it's deliberate. I could try to add overloads though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
