Tom-Newton commented on code in PR #43098:
URL: https://github.com/apache/arrow/pull/43098#discussion_r1702648561
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -3199,4 +3199,23 @@ Result<std::shared_ptr<io::OutputStream>>
AzureFileSystem::OpenAppendStream(
return impl_->OpenAppendStream(location, metadata, false, this);
}
+Result<std::string> AzureFileSystem::PathFromUri(const std::string&
uri_string) const {
+ std::string path;
+ Uri uri;
+ RETURN_NOT_OK(uri.Parse(uri_string));
+ RETURN_NOT_OK(AzureOptions::FromUri(uri, &path));
+
+ std::vector<std::string> supported_schemes = {"abfs", "abfss"};
Review Comment:
nit: It would be nice to have a comment explaining why
`internal::PathFromUriHelper()` can't be used in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]