eramitmittal commented on code in PR #43551:
URL: https://github.com/apache/arrow/pull/43551#discussion_r1703538791
##########
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/NoOpFlightSqlProducer.java:
##########
@@ -91,6 +91,15 @@ public Runnable acceptPutStatement(
throw CallStatus.UNIMPLEMENTED.withDescription("Not
implemented.").toRuntimeException();
}
+ @Override
+ public Runnable acceptPutStatementBulkIngest(
+ FlightSql.CommandStatementIngest command,
+ CallContext context,
+ FlightStream flightStream,
+ StreamListener<PutResult> ackStream) {
+ throw CallStatus.UNIMPLEMENTED.withDescription("Not
implemented.").toRuntimeException();
Review Comment:
Will do the change. However this class lacks consistency and a lot of
methods are throwing.
for e.g:
`public Runnable acceptPutStatement(
FlightSql.CommandStatementUpdate command,
CallContext context,
FlightStream flightStream,
StreamListener<PutResult> ackStream) {
throw CallStatus.UNIMPLEMENTED.withDescription("Not
implemented.").toRuntimeException();
}`
or
` @Override
public FlightInfo getFlightInfoStatement(
FlightSql.CommandStatementQuery command, CallContext context,
FlightDescriptor descriptor) {
throw CallStatus.UNIMPLEMENTED.withDescription("Not
implemented.").toRuntimeException();
}`
should I convert all to listener.OnError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
