emkornfield commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1704931224
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -789,11 +793,13 @@ class ColumnWriterImpl {
// Serializes Dictionary Page if enabled
virtual void WriteDictionaryPage() = 0;
+ using StatisticsPair = std::pair<EncodedStatistics,
std::shared_ptr<SizeStatistics>>;
Review Comment:
nit: using a custom struct can be easier to read (and should I believe still
support destructuring).
Maybe make a note that the first element isn't a pointer because it is
required but the second one is optional IIUC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
