tustvold commented on code in PR #6194:
URL: https://github.com/apache/arrow-rs/pull/6194#discussion_r1706694984
##########
object_store/src/client/retry.rs:
##########
@@ -86,6 +86,12 @@ impl Error {
path,
source: Box::new(self),
},
+ Some(StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN) => {
Review Comment:
I personally like the [gRPC status
codes](https://grpc.io/docs/guides/status-codes/) as I think these neatly
encapsulate the semantic error categories most systems need whilst not being
overly specific to one protocol, so this would be PermissionDenied and
Unauthenticated. This is also potentially more consistent with the existing
variants.
That being said I don't feel especially strongly on this
Edit: Actually we already have a NotModified variant, which is HTTP-lingo so
I think it goes either way, although I do find it confusing that HTTP returns
Unauthorized for an authentication failure...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
