pitrou commented on code in PR #43540: URL: https://github.com/apache/arrow/pull/43540#discussion_r1707355299
########## python/pyarrow/src/arrow/python/platform.h: ########## @@ -24,7 +24,9 @@ // to mean Py_ssize_t (defining this to suppress deprecation warning) #define PY_SSIZE_T_CLEAN -#include <Python.h> // IWYU pragma: export +// clang-format off: Keep pythoncapi_compat include first +#include "arrow/python/vendored/pythoncapi_compat.h" // IWYU pragma: export Review Comment: I wonder if it's a good idea to do this from a public header file. Third-party projects might then include their own vendored copy of a different version of `pythoncapi_compat.h` but still end up with the PyArrow version of that file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
