bkietz commented on code in PR #571: URL: https://github.com/apache/arrow-nanoarrow/pull/571#discussion_r1707769703
########## src/nanoarrow/common/inline_types.h: ########## @@ -314,7 +314,7 @@ static inline void ArrowErrorSetString(struct ArrowError* error, const char* src #define NANOARROW_DCHECK(EXPR) _NANOARROW_DCHECK_IMPL(EXPR, #EXPR) #else #define NANOARROW_ASSERT_OK(EXPR) (void)(EXPR) -#define NANOARROW_DCHECK(EXPR) +#define NANOARROW_DCHECK(EXPR) (void)(EXPR) Review Comment: this is a holdover from before you fixed `NANOARROW_DEBUG`, will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
