TysonStanley commented on code in PR #43634: URL: https://github.com/apache/arrow/pull/43634#discussion_r1713029975
########## r/tests/testthat/test-extra-package-roundtrip.R: ########## @@ -0,0 +1,91 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +skip_on_cran() + +# So that we can force these in CI +load_or_skip <- function(pkg) { + if (identical(tolower(Sys.getenv("ARROW_R_FORCE_EXTRA_PACKAGE_TESTS")), "true")) { + # because of this indirection on the package name we also avoid a CHECK note and + # we don't otherwise need to Suggest this + requireNamespace(pkg, quietly = TRUE) + } else { + skip_if(!requireNamespace(pkg, quietly = TRUE)) + } + attachNamespace(pkg) +} + +library(tibble) + +test_that("readr read csvs roundtrip", { + load_or_skip("readr") + + tbl <- example_data[, c("dbl", "lgl", "false", "chr")] + + tf <- tempfile() + on.exit(unlink(tf)) + write.csv(tbl, tf, row.names = FALSE) + + # we should still be able to turn this into a table + new_df <- read_csv(tf, show_col_types = FALSE) + expect_equal(new_df, as_tibble(arrow_table(new_df))) + + # we should still be able to turn this into a table + new_df <- read_csv(tf, show_col_types = FALSE, lazy = TRUE) + expect_equal(new_df, as_tibble(arrow_table(new_df))) + + # and can roundtrip to a parquet file + pq_tmp_file <- tempfile() + write_parquet(new_df, pq_tmp_file) + new_df_read <- read_parquet(pq_tmp_file) + + # we should still be able to turn this into a table + expect_equal(new_df, new_df_read) + +}) + +test_that("data.table objects roundtrip", { + load_or_skip("data.table") + + DT <- as.data.table(example_data) + + # write to parquet + pq_tmp_file <- tempfile() + write_parquet(DT, pq_tmp_file) + DT_read <- read_parquet(pq_tmp_file) + + # we should still be able to turn this into a table + expect_equal(DT, DT_read) + + # attributes are the same, aside from the internal selfref pointer + expect_mapequal(attributes(DT_read), attributes(DT)[names(attributes(DT)) != ".internal.selfref"]) + + # and we can set keys + indices + setkey(DT, chr) + setindex(DT, dbl) + + # write to parquet + pq_tmp_file <- tempfile() + write_parquet(DT, pq_tmp_file) + DT_read <- read_parquet(pq_tmp_file) + + # we should still be able to turn this into a table + expect_equal(DT, DT_read) + + # and the attributes are the same, aside from the internal selfref pointer + expect_mapequal(attributes(DT_read), attributes(DT)[names(attributes(DT)) != ".internal.selfref"]) +}) Review Comment: Those are the most important. Would also be useful to see if recently modified columns round trip well (eg, `DT[, new_col := ...]` where ... are some modification of the example data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
