jorisvandenbossche commented on code in PR #43539:
URL: https://github.com/apache/arrow/pull/43539#discussion_r1713910560
##########
ci/docker/python-wheel-manylinux-test.dockerfile:
##########
@@ -27,4 +28,5 @@ COPY python/requirements-wheel-test.txt /arrow/python/
RUN pip install -r /arrow/python/requirements-wheel-test.txt
COPY ci/scripts/install_gcs_testbench.sh /arrow/ci/scripts/
-RUN PYTHON=python /arrow/ci/scripts/install_gcs_testbench.sh default
+
+RUN PYTHON=${python} /arrow/ci/scripts/install_gcs_testbench.sh default
Review Comment:
To clarify my other suggestion:
```suggestion
RUN PYTHON_VERSION=${python} /arrow/ci/scripts/install_gcs_testbench.sh
default
```
(as I don't think this dockerfile requires exactly `python` instead of
`python3` ? Or otherwise we can also pass this `PYTHON_VERSION` env variable in
addition to the current `PYTHON` one (I just find it a bit confusing that this
`PYTHON` env variable is now used for two different things)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
