mapleFU commented on issue #43687:
URL: https://github.com/apache/arrow/issues/43687#issuecomment-2289394636
```c++
void AddAggKernel(std::shared_ptr<KernelSignature> sig, KernelInit init,
ScalarAggregateFunction* func, SimdLevel::type simd_level,
const bool ordered) {
ScalarAggregateKernel kernel(std::move(sig), std::move(init),
AggregateConsume,
AggregateMerge, AggregateFinalize, ordered);
// Set the simd level
kernel.simd_level = simd_level;
DCHECK_OK(func->AddKernel(std::move(kernel)));
}
```
Seems this would not generate one?
```cmake
append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx2.cc)
append_runtime_avx512_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx512.cc)
```
I think they've been compile with different argument, so I think the SIMD
level should be avx512 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
