alamb commented on code in PR #6231: URL: https://github.com/apache/arrow-rs/pull/6231#discussion_r1720762533
########## arrow-string/src/like.rs: ########## @@ -155,9 +156,27 @@ fn like_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) -> Result<BooleanArray, Arr /// /// This trait helps to abstract over the different types of string arrays /// so that we don't need to duplicate the implementation for each type. -trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized { +pub(crate) trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized { Review Comment: Update here is https://github.com/apache/datafusion/pull/12027 in fact we are adding something similar in datafusion as we work on porting the string functions. It seems we haven't come to an ideal solution yet but we are making progress cc @Omega359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org