kou commented on code in PR #43736:
URL: https://github.com/apache/arrow/pull/43736#discussion_r1720869420
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4965,8 +4965,21 @@ macro(build_awssdk)
set(AWSSDK_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/awssdk_ep-install")
set(AWSSDK_INCLUDE_DIR "${AWSSDK_PREFIX}/include")
+ # The AWS SDK has a few warnings around shortening lengths
+ set(AWS_C_FLAGS "${EP_C_FLAGS}")
+ set(AWS_CXX_FLAGS "${EP_CXX_FLAGS}")
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID
STREQUAL
+ "Clang")
+ # Negate warnings that AWS SDK cannot build under
+ string(APPEND AWS_C_FLAGS " -Wno-error=shorten-64-to-32")
+ string(APPEND AWS_CXX_FLAGS " -Wno-error=shorten-64-to-32")
+ endif()
+
+ set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
+ "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")
+
set(AWSSDK_COMMON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS}
+ ${AWS_EP_COMMON_CMAKE_ARGS}
Review Comment:
Can we simplify this by not defining `AWS_EP_COMMON_CMAKE_ARGS`?
```cmake
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
```
##########
dev/tasks/tasks.yml:
##########
@@ -1319,6 +1319,11 @@ tasks:
params:
MATRIX: {{ "${{ matrix.r_image }}" }}
+ test-r-macos-as-cran:
+ ci: github
+ template: r/github.macos.cran.yml
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
