ByteBaker commented on issue #6251: URL: https://github.com/apache/arrow-rs/issues/6251#issuecomment-2296921112
@kylebarron @tustvold @alamb - `name` field is optional in [Arrow spec](https://arrow.apache.org/docs/format/CDataInterface.html#c.ArrowSchema.name). - `name` field in `arrow::datatypes::Field` is required. I suppose the non-null assertion inside `FFI_ArrowSchema::name()` was originally meant to establish this guarantee for `arrow::datatypes::Field.field` but since this is the issue, what should be the course of action to resolve this? 1. Make `arrow::datatypes::Field.name` optional and make `FFI_ArrowSchema::name()` return `Option<&str>`. 2. Make `FFI_ArrowSchema::name()` return `Option<&str>` and let the user handle `None`. 3. Make `FFI_ArrowSchema::name()` return `""`. I'm personally with 2 because it leaves the control with the user and the change is minimal (in addition to being C-spec compliant) what's your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
