wjones127 commented on PR #6260: URL: https://github.com/apache/arrow-rs/pull/6260#issuecomment-2299209145
Yeah if you run the unit tests on main against AWS S3 with encryption on, the other encrpytion tests fail with: ``` thread 'aws::tests::s3_test_get_nonexistent_bucket' panicked at src/aws/mod.rs:503:9: Generic S3 error: Client error with status 400 Bad Request: <?xml version="1.0" encoding="UTF-8"?> <Error><Code>InvalidArgument</Code><Message>x-amz-server-side-encryption header is not supported for this operation.</Message><ArgumentName>x-amz-server-side-encryption</ArgumentName><ArgumentValue>aws:kms:dsse</ArgumentValue><RequestId>TBCZ37DGDBR7C1MV</RequestId><HostId>yfPR3yxVUaJiqXojttGjTiAlPJcnUImZQsoSwCCtJgFQGSbNRka+A+zpNzlXQ2MXSLvLImYvzao=</HostId></Error> ``` But after this PR, they pass again 👍 **However**, I noticed one issue. You can see here we run tests against S3 serially here: https://github.com/apache/arrow-rs/blob/e5d9816dfb7fc776732526acac3905fcb2764ef4/object_store/src/aws/mod.rs#L423-L441 But your `test_s3_ssec_encryption_with_minio` test runs in parallel. These tests interfere and often don't pass if you run the whole suite. **Could you also refactor to run serially just like the other encryption tests?** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
