crepererum commented on code in PR #6308:
URL: https://github.com/apache/arrow-rs/pull/6308#discussion_r1731194496
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -343,6 +343,16 @@ impl RowSelection {
intersect_row_selections(&self.selectors, &other.selectors)
}
+ /// Compute the union of two [`RowSelection`]
+ /// For example:
+ /// self: NNYYYYNNYYNYN
+ /// other: NYNNNNNNN
+ ///
+ /// returned: NYYYYYNNYYNYN
+ pub fn union(&self, other: &Self) -> Self {
+ union_row_selections(&self.selectors, &other.selectors)
Review Comment:
why do we need an indirection here? as far as I can tell, the called method
isn't used anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
