nealrichardson commented on a change in pull request #9641:
URL: https://github.com/apache/arrow/pull/9641#discussion_r589544073
##########
File path: r/tests/testthat/test-info.R
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Please rename this file to test-arrow-info.R, or, since you haven't
actually added a test, move this back to where it was before.
##########
File path: r/tests/testthat/test-info.R
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+test_that("arrow_info()", {
+ expect_is(arrow_info(), "arrow_info")
+ expect_output(print(arrow_info()), "Arrow package version")
+ options(arrow.foo=FALSE)
+ expect_output(print(arrow_info()), "arrow.foo")
Review comment:
I think it's ok without a direct test. I'm not sure it's worth rewriting
the `expect_output(print())` tests here to be generic enough to pass everywhere
but specific enough to test much else. And the behavior of GetRuntimeInfo
itself is tested elsewhere.
##########
File path: r/R/arrow-package.R
##########
@@ -89,7 +89,8 @@ arrow_info <- function() {
out <- list(
version = packageVersion("arrow"),
libarrow = arrow_available(),
- options = opts[grep("^arrow\\.", names(opts))]
+ options = opts[grep("^arrow\\.", names(opts))],
+ runtime = runtime_info()
Review comment:
Don't put this in the `out` object because you're going to reformat it
and add it in below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
