joellubi commented on code in PR #43861:
URL: https://github.com/apache/arrow/pull/43861#discussion_r1734412611
##########
go/parquet/file/file_reader_test.go:
##########
@@ -452,6 +452,55 @@ func TestRleBooleanEncodingFileRead(t *testing.T) {
assert.Equal(t, expected, values[:len(expected)])
}
+type mockBadReader struct {
+ cnt int
+ reader *os.File
+}
+
+func (m *mockBadReader) Seek(offset int64, whence int) (int64, error) {
+ return m.reader.Seek(offset, whence)
+}
+
+func (m *mockBadReader) ReadAt(p []byte, off int64) (n int, err error) {
+ if m.cnt == 0 {
+ return 0, fmt.Errorf("mock error")
+ }
+ m.cnt--
+ return m.reader.ReadAt(p, off)
+}
+
+func TestBadReader(t *testing.T) {
+ dir := os.Getenv("PARQUET_TEST_DATA")
+ if dir == "" {
+ t.Skip("no path supplied with PARQUET_TEST_DATA")
+ }
+ require.DirExists(t, dir)
+
+ filePath := path.Join(dir, "byte_stream_split_extended.gzip.parquet")
+ f, err := os.Open(filePath)
+ assert.NoError(t, err)
+ defer f.Close()
+
+ reader := &mockBadReader{
+ cnt: 2,
+ reader: f,
+ }
+ r, err := file.NewParquetReader(reader,
file.WithReadProps(&parquet.ReaderProperties{
+ BufferSize: int64(1024),
+ BufferedStreamEnabled: true,
+ }))
+ assert.NoError(t, err)
+
+ fileReader, err := pqarrow.NewFileReader(r,
pqarrow.ArrowReadProperties{}, memory.DefaultAllocator)
+ assert.NoError(t, err)
+
+ columnReader, err := fileReader.GetColumn(context.Background(), 0)
+ assert.NoError(t, err)
+
+ _, err = columnReader.NextBatch(1)
+ assert.Error(t, err) // Expect an error to occur.
Review Comment:
```suggestion
assert.ErrorContains(t, err, "mock error") // Expect an error to occur.
```
Minor suggestion to make it clear that the intended error was the cause here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
