double-free commented on PR #6269: URL: https://github.com/apache/arrow-rs/pull/6269#issuecomment-2315883658
> Thank you @double-free -- the explanation and code look good to me. I am sorry for the delay in reviewing > > My only question is related to renaming of the `struct` in the tests -- could you double check that and respond to my question? > > Thanks again Hi, I have replied to those questions. Please review again. Btw, can you point me where to update the document of `parquet_derive`? If we choose to merge the PR, this statement will be outdated: > Column readers are generated in the order they are defined. Column readers are generated according to names instead of indices now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
