kylebarron commented on code in PR #6320:
URL: https://github.com/apache/arrow-rs/pull/6320#discussion_r1735211922
##########
arrow-pyarrow-integration-testing/tests/test_sql.py:
##########
@@ -476,6 +476,27 @@ def test_tensor_array():
del b
+
+def test_empty_recordbatch_with_row_count():
Review Comment:
I suppose CI is likely always testing with the most recent version of
pyarrow, and thus we _only_ really test with the PyCapsule Interface, not with
the pyarrow-specific FFI. If you wanted to ensure you're testing the PyCapsule
Interface, you can create a wrapper class around a `pa.RecordBatch` that only
exposes the PyCapsule dunder method:
https://github.com/pola-rs/polars/blob/b2550a092e34aa40f8786f45ff67cab96c93695d/py-polars/tests/unit/constructors/test_constructors.py#L1661-L1676
Then you can be assured that
```py
rust.round_trip_record_batch(PyCapsuleArrayHolder(batch))
```
is testing the PyCapsule Interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
