bkietz commented on code in PR #6321:
URL: https://github.com/apache/arrow-rs/pull/6321#discussion_r1735431150
##########
arrow-ipc/src/writer.rs:
##########
@@ -824,12 +824,12 @@ impl DictionaryTracker {
pub struct FileWriter<W> {
/// The object to write to
writer: W,
+ /// The number of bytes written
+ written_len: usize,
/// IPC write options
write_options: IpcWriteOptions,
/// A reference to the schema, used in validating record batches
schema: SchemaRef,
- /// The number of bytes between each block of bytes, as an offset for
random access
- block_offsets: usize,
Review Comment:
This is the former mechanism for tracking absolute position in the output
file. It was named according to the only thing it was used for: setting
`Block::offset`s. Since it's now used to track how much padding should be
written after flatbuffers Messages and to make its expected value more obvious,
I renamed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
