rok commented on code in PR #13901:
URL: https://github.com/apache/arrow/pull/13901#discussion_r1737557423
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -1387,8 +1394,8 @@ using TestLargeBinaryParquetIO =
TestParquetIO<::arrow::LargeBinaryType>;
TEST_F(TestLargeBinaryParquetIO, Basics) {
const char* json = "[\"foo\", \"\", null, \"\xff\"]";
- const auto large_type = ::arrow::large_binary();
- const auto narrow_type = ::arrow::binary();
+ const auto large_type = ::arrow::large_utf8();
+ const auto narrow_type = ::arrow::utf8();
const auto large_array = ::arrow::ArrayFromJSON(large_type, json);
Review Comment:
Just a mistake. Reverting.
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -1410,8 +1417,8 @@ using TestLargeStringParquetIO =
TestParquetIO<::arrow::LargeStringType>;
TEST_F(TestLargeStringParquetIO, Basics) {
const char* json = R"(["foo", "", null, "bar"])";
- const auto large_type = ::arrow::large_utf8();
- const auto narrow_type = ::arrow::utf8();
+ const auto large_type = ::arrow::large_binary();
+ const auto narrow_type = ::arrow::binary();
Review Comment:
Mistake. Reverting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
