tustvold commented on code in PR #4584:
URL: https://github.com/apache/arrow-rs/pull/4584#discussion_r1740445892


##########
arrow-array/src/array/byte_array.rs:
##########
@@ -159,7 +159,7 @@ impl<T: ByteArrayType> GenericByteArray<T> {
     /// # Safety
     ///
     /// Safe if [`Self::try_new`] would not error
-    pub fn new_unchecked(
+    pub unsafe fn new_unchecked(

Review Comment:
   See the checks done by try_new, in particular that the offsets are valid, 
and the data is UTF-8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to