paleolimbot commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1747873702
##########
src/nanoarrow/testing/testing.cc:
##########
@@ -1932,6 +1940,7 @@ ArrowErrorCode SetArrayColumnBuffers(const json& value,
ArrowArrayView* array_vi
}
break;
}
+ case NANOARROW_BUFFER_TYPE_DATA_VIEW: // TODO: doesn't seem right?
Review Comment:
You can probably punt on this for this PR...it's basically generating this:
https://arrow.apache.org/docs/format/Integration.html#json-test-data-format ,
scroll down to `FieldData`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
