jonkeane commented on a change in pull request #9663:
URL: https://github.com/apache/arrow/pull/9663#discussion_r590550879
##########
File path: r/R/dplyr.R
##########
@@ -514,7 +515,7 @@ mutate.arrow_dplyr_query <- function(.data,
if (!quo_is_null(.before) || !quo_is_null(.after)) {
# TODO(ARROW-11701)
return(abandon_ship(call, .data, '.before and .after arguments are not
supported in Arrow'))
- } else if (length(group_vars(.data)) > 0) {
+ } else if (length(dplyr::group_vars(.data)) > 0) {
Review comment:
This might not be the absolutely right way to do this: at this point we
will be using `group_vars.arrow_dplyr_query` which we do define, but R CMD
check isn't able to catch that.
`dplyr::group_vars` is simply `UseMethod("group_vars")` so this should just
work, but there might be a more approved solution for this case of referencing
an s3 method without importing it directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
