paleolimbot commented on code in PR #43977:
URL: https://github.com/apache/arrow/pull/43977#discussion_r1757196419
##########
cpp/src/parquet/statistics.h:
##########
@@ -114,19 +115,79 @@ std::shared_ptr<TypedComparator<DType>>
MakeComparator(const ColumnDescriptor* d
return
std::static_pointer_cast<TypedComparator<DType>>(Comparator::Make(descr));
}
+class PARQUET_EXPORT EncodedGeometryStatistics {
+ public:
+ static constexpr double kInf = std::numeric_limits<double>::infinity();
+
+ EncodedGeometryStatistics() = default;
+ EncodedGeometryStatistics(const EncodedGeometryStatistics&) = default;
+ EncodedGeometryStatistics(EncodedGeometryStatistics&&) = default;
+ EncodedGeometryStatistics& operator=(const EncodedGeometryStatistics&) =
default;
+
+ double xmin{kInf};
+ double xmax{-kInf};
+ double ymin{kInf};
+ double ymax{-kInf};
+ double zmin{kInf};
+ double zmax{-kInf};
+ double mmin{kInf};
+ double mmax{-kInf};
+ std::vector<std::pair<std::string, std::string>> coverings;
+ std::vector<uint32_t> geometry_types;
Review Comment:
(It was initially this way because the `uint32_t` is what is used to pull
the geometry type out of WKB, but there's no need to propagate that outside the
WKB reading code 🙂 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
