Dandandan commented on code in PR #6402:
URL: https://github.com/apache/arrow-rs/pull/6402#discussion_r1761797487
##########
arrow-cast/src/display.rs:
##########
@@ -423,7 +423,7 @@ macro_rules! primitive_display {
let mut buffer = [0u8; <$t as
ArrowPrimitiveType>::Native::FORMATTED_SIZE];
// SAFETY:
// buffer is T::FORMATTED_SIZE
- let b = unsafe { lexical_core::write_unchecked(value, &mut
buffer) };
+ let b = lexical_core::write(value, &mut buffer);
Review Comment:
Safety comment above this can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]