seddonm1 commented on pull request #9428: URL: https://github.com/apache/arrow/pull/9428#issuecomment-796301063
@sweb this looks like it is getting there 👍 The flags are super messy in the SQL Posix fmt vs the Rust regex so you have that to look forward to. We do need to try to reuse some code but unfortunately that means either lifting the current regexp_expressions logic into a kernel or the moving your logic to the regexp file. I think if you can get to the point of making it work and lots of test then we can always refactor for performance later (as we better understand the problems). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
