andygrove commented on code in PR #6419: URL: https://github.com/apache/arrow-rs/pull/6419#discussion_r1767362864
########## arrow-data/src/decimal.rs: ########## @@ -644,8 +650,11 @@ pub(crate) const MIN_DECIMAL_BYTES_FOR_LARGER_EACH_PRECISION: [i256; 76] = [ ]; /// `MAX_DECIMAL_FOR_EACH_PRECISION[p]` holds the maximum `i128` value that can -/// be stored in [arrow_schema::DataType::Decimal128] value of precision `p` -pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [ +/// be stored in [arrow_schema::DataType::Decimal128] value of precision `p`. +/// The first element is unused and is inserted so that we can look up using +/// precision as the index without the need to subtract 1 first. +pub(crate) const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 39] = [ Review Comment: Note the change from `pub` to `pub(crate)`, technically an API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
