paleolimbot commented on code in PR #2166:
URL: https://github.com/apache/arrow-adbc/pull/2166#discussion_r1769335723
##########
go/adbc/drivermgr/wrapper_sqlite_test.go:
##########
@@ -190,10 +190,6 @@ func (dm *DriverMgrSuite) TestGetObjectsCatalog() {
expSchema := adbc.GetObjectsSchema
dm.True(expSchema.Equal(rdr.Schema()))
- dm.True(rdr.Next())
-
- rec := rdr.Record()
- dm.Equal(int64(0), rec.NumRows())
Review Comment:
@zeroshade The change that triggered this was that the internal helper that
generates streams from arrays will now canonically generate an empty stream
instead of a stream with one array of length zero. I think this is slightly
nicer but can revert it if you think it will cause problems!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
